-- Sent from mobile phone (so please have understanding) On 7 gru 2012, at 12:06, Spiro Trikaliotis <ml-cbmhackers@trikaliotis.net> wrote: > Good catch. > > VICE includes the opencbm.h file directly in the source distribution of > VICE. Oops! > Unfortunately, that file there is old, As can be expected with such approach. Similar in a way to hard coding paths. > and it does not handle 64 > bit platforms. Today it doesn't handle typical lib locations and 64 bits, tomorrow something else.. This seems to be another quasi-bug to be reported to VICE team as someone already suggested. I can't verify it out now as I am travelling but it very much "smells" bad enough to me to be the potential reason of the problem. > Replacing it (src/opencbm.h) through the opencbm.h file from the git > head of OpenCBM (opencbm/include/opencbm.h) might fix the issue. > > Of course, it is arguable if opencbm.h should be in the VICE source > distribution in the first place. I know that this has always been the > case with VICE with different libraries, in order to make VICE > self-compiling. But isn't it what the ./configure should be for? If I --disable-realdevice or --disable-opencbm vice should still compile without looking for the opencbm.h include file, shouldn't it be so? The same with other libs I guess. > In the long run, it might harm VICE more. This means > VICE cannot benefit from updates in the 3rd party libraries: Here of 64 > bit additions of OpenCBM, in other cases (compression library) of > security bug fixes... Definitely. Relying on "own" header files for accessing an external, dynamic lib of completely unknown version is a bad concept.. I can imagine OpenCBM to be fully integrated into vice source tree and being given a separate "make" target for example if that would be what authors wished. That way both could be developed in parallel, and still remain separate products. But not like this. Otherwise it should depend on the actual header files present in the appropriate include libs of the system. You are no longer member of vice team Spiro, are you? -- SD! Message was sent through the cbm-hackers mailing listReceived on 2012-12-07 17:00:10
Archive generated by hypermail 2.2.0.